Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking on the Search tab should return to the search card #4403

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 30, 2023

Hi everyone,

I've a bit reworked how the Carousel is managed externally (basically the controller is not available outside the Widget).
It means we can change the tab and thus go back correctly to the search card when we tap on the Search tab.
I've also ensured to minimize the calls to dependOn, as it was clearly not needed.

I've also renamed InheritedDataManager with ExternalCarouselManager which is more relevant.

It should fix #4369

@g123k g123k self-assigned this Jul 30, 2023
@g123k g123k requested a review from a team as a code owner July 30, 2023 07:06
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… and removed summary card labels Jul 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4403 (d47c34f) into develop (05850f3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4403   +/-   ##
========================================
  Coverage    10.17%   10.18%           
========================================
  Files          295      295           
  Lines        15045    15033   -12     
========================================
  Hits          1531     1531           
+ Misses       13514    13502   -12     
Files Changed Coverage Δ
...e_panel/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...ackages/smooth_app/lib/pages/carousel_manager.dart 0.00% <0.00%> (ø)
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% <0.00%> (ø)
...ib/pages/onboarding/onboarding_flow_navigator.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/pages/page_manager.dart 0.00% <0.00%> (ø)
...p/lib/pages/product/common/product_list_modal.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.45% <0.00%> (ø)
...mooth_app/lib/widgets/smooth_product_carousel.dart 1.67% <0.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit a6cdcaf into openfoodfacts:develop Jul 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page product scan carousel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] The Scanner icon in the bottom bar should return to the first element
3 participants