Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When there is just a close button, the product card should have a full-width title #4404

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 30, 2023

Hi everyone,

In the carousel, product cards have a close button, but we lose so much space (here in red):
Screenshot_20230730-090735

This PR fixes with:
Screenshot_20230730-091107

Note: This one + #4357 should really improve the layout on small screens

@g123k g123k self-assigned this Jul 30, 2023
@g123k g123k requested a review from a team as a code owner July 30, 2023 07:14
@codecov-commenter
Copy link

Codecov Report

Merging #4404 (81ab9ac) into develop (05850f3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4404      +/-   ##
===========================================
- Coverage    10.17%   10.17%   -0.01%     
===========================================
  Files          295      295              
  Lines        15045    15046       +1     
===========================================
  Hits          1531     1531              
- Misses       13514    13515       +1     
Files Changed Coverage Δ
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon
Copy link
Member

I would really like to move the close button elsewhere (possibly outside the card, as an overlay, or in the compatibility bar, but then we need to do something with the cogwheel)

@g123k
Copy link
Collaborator Author

g123k commented Jul 30, 2023

I would really like to move the close button elsewhere (possibly outside the card, as an overlay, or in the compatibility bar, but then we need to do something with the cogwheel)

I think the best place would indeed be in the compatibility bar.

Here is a possible implementation:

  • Why not replace the settings-like icon by the 'Close' one
  • We made the full compatibility bar tappable + add an 'Info' icon on the left
    By clicking on this icon, we would have a small dialog to explain what is this value (because we don't explain it clearly). And in this dialog, there would be a link to the food prefs.

@teolemon teolemon merged commit f5a74c5 into openfoodfacts:develop Jul 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants