Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The "beeeep" is back 🔊 #4436

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix: The "beeeep" is back 🔊 #4436

merged 1 commit into from
Aug 4, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 4, 2023

Hi everyone,

I don't really understand the issue here, because according to the doc, we should only open once an asset file and call stop / resume. But if I do the same by resetting the file every time, it now works 🤨

@g123k g123k added 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… camera labels Aug 4, 2023
@g123k g123k requested a review from a team as a code owner August 4, 2023 08:25
@g123k g123k self-assigned this Aug 4, 2023
@g123k g123k linked an issue Aug 4, 2023 that may be closed by this pull request
Beep on scan does not work #3915
Closed
@g123k g123k mentioned this pull request Aug 4, 2023
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #4436 (ea4fef6) into develop (a5e1808) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4436   +/-   ##
========================================
  Coverage    10.17%   10.17%           
========================================
  Files          295      295           
  Lines        15093    15090    -3     
========================================
  Hits          1535     1535           
+ Misses       13558    13555    -3
Files Changed Coverage Δ
packages/smooth_app/lib/pages/scan/scan_page.dart 2.15% <0.00%> (+0.06%) ⬆️
...mooth_app/lib/widgets/smooth_product_carousel.dart 1.67% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

monsieurtanuki
monsieurtanuki approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @g123k!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

You can test this PR on: Android

@teolemon teolemon merged commit 29e2ec4 into openfoodfacts:develop Aug 4, 2023
7 checks passed
@g123k g123k mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

Assignees

@g123k g123k

Labels
camera dependencies product scan carousel scan sound 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beep on scan does not work
4 participants
@g123k @codecov-commenter @monsieurtanuki @teolemon