Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setState called in a build method #4438

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix: setState called in a build method #4438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/smooth_app/lib/pages/carousel_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class ExternalCarouselManager extends StatefulWidget {
class ExternalCarouselManagerState extends State<ExternalCarouselManager> {
final CarouselController _controller = CarouselController();

String? _currentBarcode;
String? currentBarcode;

@override
Widget build(BuildContext context) {
Expand All @@ -60,13 +60,8 @@ class ExternalCarouselManagerState extends State<ExternalCarouselManager> {

CarouselController get controller => _controller;

String? get currentBarcode => _currentBarcode;

set currentBarcode(String? barcode) =>
setState(() => _currentBarcode = barcode);

bool updateShouldNotify(ExternalCarouselManagerState oldState) {
return oldState.currentBarcode != _currentBarcode;
return oldState.currentBarcode != currentBarcode;
}
}

Expand Down