Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure the SmoothSimpleButton has a border on AMOLED theme #4440

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 4, 2023

Hi everyone,

When we use the SmoothSimpleButton and only with the AMOLED theme, there is no shadow, nor a Ripple color.
However, after testing it a bit, a border fits better.

Before:
Screenshot_20230804-144537

After:
Screenshot 2023-08-04 at 15 06 14

@g123k g123k requested a review from a team as a code owner August 4, 2023 13:06
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

You can test this PR on: Android

@teolemon
Copy link
Member

teolemon commented Aug 4, 2023

❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart: SmoothErrorCard exist (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart: SmoothErrorCard doesnt find the error message (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart: SmoothErrorCard find error message (failed)

@codecov-commenter
Copy link

Codecov Report

Merging #4440 (b5cbb3f) into develop (13e6d54) will increase coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 55.55%.

@@             Coverage Diff             @@
##           develop    #4440      +/-   ##
===========================================
+ Coverage    10.17%   10.20%   +0.02%     
===========================================
  Files          295      295              
  Lines        15087    15096       +9     
===========================================
+ Hits          1535     1540       +5     
- Misses       13552    13556       +4     
Files Changed Coverage Δ
packages/smooth_app/lib/themes/theme_provider.dart 40.90% <33.33%> (-1.20%) ⬇️
.../lib/generic_lib/buttons/smooth_simple_button.dart 86.36% <66.66%> (-7.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit 390aa65 into openfoodfacts:develop Aug 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants