-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hunger games: a better loading view + we finally support errors… #4448
Conversation
…ach state is a dedicated Widget
Codecov Report
@@ Coverage Diff @@
## develop #4448 +/- ##
===========================================
- Coverage 10.17% 10.14% -0.03%
===========================================
Files 295 295
Lines 15087 15154 +67
===========================================
+ Hits 1535 1538 +3
- Misses 13552 13616 +64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You can test this PR on: Android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why we try to make Hunger Games an overlay vs a dedicated screen. (I do understand it when the widget is shown on a product)
@@ -2392,5 +2392,9 @@ | |||
"nova_group_2": "NOVA Group 2", | |||
"nova_group_3": "NOVA Group 3", | |||
"nova_group_4": "NOVA Group 4", | |||
"nova_group_unknown": "Unknown NOVA Group" | |||
"nova_group_unknown": "Unknown NOVA Group", | |||
"hunger_games_loading_line1": "Please let us a few seconds…", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hunger_games_loading_line1": "Please let us a few seconds…", | |
"hunger_games_loading_line1": "Just a few seconds…", |
"nova_group_unknown": "Unknown NOVA Group" | ||
"nova_group_unknown": "Unknown NOVA Group", | ||
"hunger_games_loading_line1": "Please let us a few seconds…", | ||
"hunger_games_loading_line2": "We're downloading the questions!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a We/You wording?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's a game, that why I've switched to a more familiar language, but feel free to revert this change
You're totally right and would be interesting to also use the onboarding from the website, to clarify that's another feature from the main app. I note this for next "sprint". |
Hi everyone,
I've reworked a bit the Hunger game page, with:
FutureBuilder
, hence needing a bit more codeSome screenshots:
Loading:
Question card:
Error: