-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add the brand name in the AppBar #4449
Conversation
You can test this PR on: Android |
Codecov Report
@@ Coverage Diff @@
## develop #4449 +/- ##
===========================================
- Coverage 10.28% 10.28% -0.01%
===========================================
Files 296 296
Lines 15232 15234 +2
===========================================
Hits 1567 1567
- Misses 13665 13667 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your implementation is partial.
You have only changed the main page, but we should have the product name first.
Also in some languages, there is a space between the two info.
- this bug is not only for this page, but also but all subpages
Why did you close your PR @saiprasad-patil? It was possible to add the new features in it |
I'm sorry I'll create a new PR, I'm new to Github and a beginner in general. |
Added the brand name in the App Bar
Screenshot
Fixes bug(s)