fix: smooth_error_card_test.dart

[monsieurtanuki]

What

• Fixes the following error:

Run flutter analyze --fatal-infos --fatal-warnings .
Analyzing smooth-app...                                         

  error • Target of URI doesn't exist: 'package:smooth_app/data_models/user_preferences.dart' • packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart:6:8 • uri_does_not_exist
  error • Undefined class 'UserPreferences' • packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart:54:[11](https://github.com/openfoodfacts/smooth-app/actions/runs/5771595299/job/15645721358#step:9:12) • undefined_class
   info • Method invocation or property access on a 'dynamic' target • packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart:54:41 • avoid_dynamic_calls
  error • Undefined name 'UserPreferences' • packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart:54:41 • undefined_identifier

4 issues found. (ran in 43.7s)

[codecov-commenter]

Codecov Report

Merging #4451 (a62267f) into develop (6fd6aa8) will increase coverage by 0.02%.
Report is 5 commits behind head on develop.
The diff coverage is 55.55%.

@@             Coverage Diff             @@
##           develop    #4451      +/-   ##
===========================================
+ Coverage    10.26%   10.28%   +0.02%     
===========================================
  Files          296      296              
  Lines        15223    15232       +9     
===========================================
+ Hits          1562     1567       +5     
- Misses       13661    13665       +4     

Files Changed	Coverage Δ
packages/smooth_app/lib/themes/theme_provider.dart	40.90% <33.33%> (-1.20%)	⬇️
.../lib/generic_lib/buttons/smooth_simple_button.dart	86.36% <66.66%> (-7.39%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[monsieurtanuki]

@teolemon @g123k @M123-dev Perhaps the waldo process should be improved.

For instance, this is a very minor PR, and still it's automatically entered in the waldo queue. Problem: 1) here we don't really need waldo 2) we're kind of blocked and blocking other waldo processes that would make sense.

And in #4255 I'm not sure if the waldo was triggered automatically or after a manual intervention. Anyway that wouldn't make sense to create a new waldo each time the "Update branch" button is clicked.

What about an "on demand" waldo?

[g123k]

@teolemon @g123k @M123-dev Perhaps the waldo process should be improved.

For instance, this is a very minor PR, and still it's automatically entered in the waldo queue. Problem: 1) here we don't really need waldo 2) we're kind of blocked and blocking other waldo processes that would make sense.

And in #4255 I'm not sure if the waldo was triggered automatically or after a manual intervention. Anyway that wouldn't make sense to create a new waldo each time the "Update branch" button is clicked.

What about an "on demand" waldo?

This is what I want to change and the same goes to the release process.
For each merged PRs, the app is sent to the Google Play and the App Store, we should also do it on demand.

[g123k]

I don't really understand why we have this warning, because the PR #4450 was passing…
I'm sorry for this

[monsieurtanuki]

I don't really understand why we have this warning, because the PR #4450 was passing… I'm sorry for this

I don't know either. Anyway, now it's fixed!

[github-actions]

You can test this PR on: Android