Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change "Release please" to be manually triggered #4453

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 5, 2023

Hi everyone,

For each merged PR, this is a new commit on develop, which triggers the "Run release-please action".
Basically, it will build an Android application and send it to Google Play and the same goes for iOS and TestFlight.

This PR change it to be manually triggered on by admins.
Unfortunately, there is no way to filter by role, so the only solution I've found is a list of usernames 😖

@g123k g123k self-assigned this Aug 5, 2023
@g123k g123k requested a review from a team as a code owner August 5, 2023 17:58
@github-actions github-actions bot added the GitHub label Aug 5, 2023
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release please is supposed to run on every commit, it just created the release PR and creates a release when merged

The internal release file should be edited

@g123k
Copy link
Collaborator Author

g123k commented Aug 5, 2023

Release please is supposed to run on every commit, it just created the release PR and creates a release when merged

The internal release file should be edited

Oops sorry, you're right.
Would that be better?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

You can test this PR on: Android

@g123k
Copy link
Collaborator Author

g123k commented Aug 7, 2023

Is-it OK now @M123-dev? 😀

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right 👍🏻

@codecov-commenter
Copy link

Codecov Report

Merging #4453 (c4f27ef) into develop (520b90c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4453   +/-   ##
========================================
  Coverage    10.36%   10.36%           
========================================
  Files          296      296           
  Lines        15241    15241           
========================================
  Hits          1579     1579           
  Misses       13662    13662           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit 8ee0f87 into openfoodfacts:develop Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants