-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Change "Release please" to be manually triggered #4453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release please is supposed to run on every commit, it just created the release PR and creates a release when merged
The internal release file should be edited
Oops sorry, you're right. |
You can test this PR on: Android |
Is-it OK now @M123-dev? 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right 👍🏻
Codecov Report
@@ Coverage Diff @@
## develop #4453 +/- ##
========================================
Coverage 10.36% 10.36%
========================================
Files 296 296
Lines 15241 15241
========================================
Hits 1579 1579
Misses 13662 13662 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi everyone,
For each merged PR, this is a new commit on
develop
, which triggers the "Run release-please action".Basically, it will build an Android application and send it to Google Play and the same goes for iOS and TestFlight.
This PR change it to be manually triggered on by admins.
Unfortunately, there is no way to filter by role, so the only solution I've found is a list of usernames 😖