Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Error message when the access to the user gallery is denied (iOS only) #4464

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 7, 2023

Hi everyone,

We currently have the following issue:

  • The app asks the user to select a source (camera/gallery)
  • He/she selects the gallery and denied the popup from iOS
  • The next time he/she clicks on the gallery, nothing will happen in the app

We now support this case by explaining the problem and redirecting to the settings.
It's also an iOS-only issue.

It will fix #4462

Simulator Screenshot - iPhone 14 Pro Max - 2023-08-07 at 08 58 52

@g123k g123k added 🍎 iOS iOS specific issues or PRs permissions labels Aug 7, 2023
@g123k g123k self-assigned this Aug 7, 2023
@g123k g123k requested a review from a team as a code owner August 7, 2023 07:04
@codecov-commenter
Copy link

Codecov Report

Merging #4464 (33fac11) into develop (520b90c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4464      +/-   ##
===========================================
- Coverage    10.36%   10.34%   -0.02%     
===========================================
  Files          296      296              
  Lines        15241    15267      +26     
===========================================
  Hits          1579     1579              
- Misses       13662    13688      +26     
Files Changed Coverage Δ
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 67.85% <0.00%> (-0.35%) ⬇️
packages/smooth_app/lib/pages/image_crop_page.dart 0.79% <0.00%> (-0.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

You can test this PR on: Android

@teolemon teolemon merged commit 6e15568 into openfoodfacts:develop Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] If we previously denied the access to the gallery, the button does nothing…
3 participants