Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use the latest version of mobile_scanner #4472

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 7, 2023

Hi everyone,

Good news! My PR to fix #4413 is merged in mobile_scanner + a 3.4.0 version is released.
That's why we can re-use the package from Pub.dev

Will also fix #4284

@g123k g123k added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Aug 7, 2023
@g123k g123k self-assigned this Aug 7, 2023
@g123k g123k requested a review from a team as a code owner August 7, 2023 09:50
@github-actions github-actions bot added dependencies and removed 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Aug 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4472 (be5db79) into develop (520b90c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4472   +/-   ##
========================================
  Coverage    10.36%   10.36%           
========================================
  Files          296      296           
  Lines        15241    15241           
========================================
  Hits          1579     1579           
  Misses       13662    13662           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

You can test this PR on: Android

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to retest scanning to ensure no regressions, and that this actually solves the issue.

@teolemon teolemon merged commit c0a1533 into openfoodfacts:develop Aug 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking away on share app crashed the app Use back mobile_scanner pub.dev release
3 participants