Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add some config files for iOS translations #4479

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 8, 2023

Hi everyone,

That one was really tricky to fix, but finally translations for NSCameraUsageDescription work.
Basically, if even with the change, you still have the message in English, please run a flutter clean

Screenshot in French (on a real device)
IMG_7EB423A81F80-1

@g123k g123k added 🍎 iOS iOS specific issues or PRs translations labels Aug 8, 2023
@g123k g123k self-assigned this Aug 8, 2023
@g123k g123k requested a review from a team as a code owner August 8, 2023 06:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

You can test this PR on: Android

@g123k g123k linked an issue Aug 8, 2023 that may be closed by this pull request
@@ -0,0 +1 @@
NSCameraUsageDescription = "Cette application a besoin d'un accès à l'appareil photo pour scanner des codes à barres et pour prendre des photos de produits";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be in English? @g123k

@teolemon teolemon merged commit 6c705c2 into openfoodfacts:develop Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific issues or PRs translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] The permission description is not translated
2 participants