fix: On iOS, the "beep" sound was silent #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🤳🥫 Scan
Codecov Report
@@ Coverage Diff @@
## develop #4480 +/- ##
========================================
Coverage 10.36% 10.36%
========================================
Files 296 296
Lines 15241 15241
========================================
Hits 1579 1579
Misses 13662 13662
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You can test this PR on: Android |
|
TODO: Check in the settings if Do not Disturb is off/on and notify the user about the scan sound |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I wonder if the scan sound ever worked, but it's now OK.
Note for future releases: check in the settings if DND is off and notify the user