Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: On the product page: ensure to refresh the screen if the product is added/removed from a list #4486

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 8, 2023

Hi everyone,

This is not a major bug, but when we add/remove a product to a list, from the product page, nothing happens.
Basically, events were not dispatched correctly.

New behavior:
Lists.webm

@g123k g123k self-assigned this Aug 8, 2023
@g123k g123k requested a review from a team as a code owner August 8, 2023 08:34
@g123k g123k linked an issue Aug 8, 2023 that may be closed by this pull request
@github-actions github-actions bot added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

You can test this PR on: Android

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, unsure about what:
if (refreshed != null && refreshed) {
if (refreshed == true) {
implies

@g123k
Copy link
Collaborator Author

g123k commented Aug 9, 2023

Looks good, unsure about what: if (refreshed != null && refreshed) { if (refreshed == true) { implies

Refreshed can be null, but directly telling is true is quicker

@teolemon teolemon merged commit 69b3b43 into openfoodfacts:develop Aug 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page User lists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product -> Add to a list -> The product view is not refreshed
2 participants