Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert to a custom fork of mobile_scanner #4519

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 14, 2023

Hi everyone,

We are forced to revert to the custom fork of mobile_scanner as there is a MAJOR issue on iOS.
Basically, it's the latest version of the lib minus the faulty commit

https://github.com/openfoodfacts/mobile_scanner/commits/custom_release

…n iOS.

Basically, it's the latest version (3.4.1) minus the faulty commit
@g123k g123k added dependencies 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… pubspec labels Aug 14, 2023
@g123k g123k requested a review from a team as a code owner August 14, 2023 05:57
@g123k g123k self-assigned this Aug 14, 2023
@github-actions github-actions bot removed the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Aug 14, 2023
@g123k g123k linked an issue Aug 14, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #4519 (0469730) into develop (ee9e20f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4519   +/-   ##
========================================
  Coverage    10.32%   10.32%           
========================================
  Files          296      296           
  Lines        15290    15290           
========================================
  Hits          1579     1579           
  Misses       13711    13711           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit 1bd9c4d into openfoodfacts:develop Aug 14, 2023
6 checks passed
@teolemon
Copy link
Member

Thank you. Deploying in TestFlight now

1 similar comment
@teolemon
Copy link
Member

Thank you. Deploying in TestFlight now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXC_BREAKPOINT: Exception 6, Code 24684320, Subcode 8
4 participants