Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4533 - new twitter logo and label #4539

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • New tinted icon and English label for twitter.

Screenshot

light dark
Screenshot_2023-08-15-14-33-00 Screenshot_2023-08-15-14-32-38

Fixes bug(s)

Files

Deleted file:

  • twitter-bird.svg

New file:

  • x-logo.svg

Impacted files:

  • app_en.arb: edited twitter label
  • user_preferences_connect.dart: now using the new tinted twitter logo

Deleted file:
* `twitter-bird.svg`

New file:
* `x-logo.svg`

Impacted files:
* `app_en.arb`: edited twitter label
* `user_preferences_connect.dart`: now using the new tinted twitter logo
@codecov-commenter
Copy link

Codecov Report

Merging #4539 (a25df21) into develop (439aeb4) will decrease coverage by 0.01%.
Report is 9 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4539      +/-   ##
===========================================
- Coverage    10.32%   10.31%   -0.01%     
===========================================
  Files          296      296              
  Lines        15296    15306      +10     
===========================================
  Hits          1579     1579              
- Misses       13717    13727      +10     
Files Changed Coverage Δ
...ib/pages/preferences/user_preferences_connect.dart 5.26% <0.00%> (-0.10%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Note for myself: improve accessibility for this)

@monsieurtanuki monsieurtanuki merged commit c532180 into openfoodfacts:develop Aug 15, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter isn't coming back
3 participants