chore: Migration to Flutter 3.13

[g123k]

Hi everyone,

Since the release is in a few days, we can already test if there is no regression with the latest stable version of Flutter.
In terms of code, there's no real breaking change.

[monsieurtanuki]

I have seen nothing shocking in that PR.
But I would wait about a month to see the first bug fixes, instead of rushing as soon as the first week of that new version's availability.
The new horizontal+vertical scrolling feature is not good enough a reason to do it, IMHO.

[monsieurtanuki]

While you're here you should probably change targetSdk too.

[g123k]

I have seen nothing shocking in that PR. But I would wait about a month to see the first bug fixes, instead of rushing as soon as the first week of that new version's availability. The new horizontal+vertical scrolling feature is not good enough a reason to do it, IMHO.

There's also the fix for iOS, which is important (but also available on 3.10.7.
My point here is maybe to merge it, since we don't need to rush on the release and be pretty confident that the D day, there's no surprise

[monsieurtanuki]

There's also the fix for iOS, which is important (but also available on 3.10.7. My point here is maybe to merge it, since we don't need to rush on the release and be pretty confident that the D day, there's no surprise

Upgrading to 3.10.7 would then be the wisest option. In the past other flutter developers (not us specifically) raised issues about new flutter versions and we quietly waited until most bug were fixed. I can see no good reason to rush this time.

[codecov-commenter]

Codecov Report

Merging #4579 (53acc5c) into develop (53a75a3) will increase coverage by 9.91%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #4579      +/-   ##
==========================================
+ Coverage         0   9.91%   +9.91%     
==========================================
  Files            0     310     +310     
  Lines            0   15792   +15792     
==========================================
+ Hits             0    1566    +1566     
- Misses           0   14226   +14226     

Files	Coverage Δ
...b/bottom_sheets/smooth_draggable_bottom_sheet.dart	0.00% <ø> (ø)
...om_sheets/smooth_draggable_bottom_sheet_route.dart	0.00% <ø> (ø)
...app/lib/pages/product/ordered_nutrients_cache.dart	0.00% <ø> (ø)
packages/smooth_app/lib/themes/smooth_theme.dart	76.08% <ø> (ø)
...l/knowledge_panels/knowledge_panel_group_card.dart	0.00% <0.00%> (ø)
...l/knowledge_panels/knowledge_panel_table_card.dart	0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart	0.80% <0.00%> (ø)
...ib/pages/preferences/user_preferences_rate_us.dart	3.57% <0.00%> (ø)
...eferences/user_preferences_share_with_friends.dart	4.00% <0.00%> (ø)
packages/smooth_app/lib/main.dart	13.38% <0.00%> (ø)
... and 2 more

... and 298 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[teolemon]

With a 3.13.1, I'd be tempted to merge anyway.

[monsieurtanuki]

With a 3.13.1, I'd be tempted to merge anyway.

Sidenote: we may also have to check if the github action computers upgraded to 3.13.

[teolemon]

Although I did merge @monsieurtanuki's simple bump, I'd like this bump to go through as well.
I haven't heard any issues on the general release, nor the dot one.

[g123k]

Although I did merge @monsieurtanuki's simple bump, I'd like this bump to go through as well. I haven't heard any issues on the general release, nor the dot one.

I use it daily (on Android and iOS) and I haven't noticed any regression, so why not

[monsieurtanuki]

For the record I'm not blocking anything here.

• Do I find an added-value in the upgrade: no
• Would I upgrade now: no
• Would I find it catastrophic to upgrade now: no

@teolemon @g123k Don't be shy and upgrade if you want! 😉

Disclaimer: I don't know when the next release takes place.

[monsieurtanuki]

@g123k They released 3.13.5 a week ago. I guess hope we're safe now!

[g123k]

Unfortunately .5 is NOT a good release, because it breaks the fact to test on an iPhone (= a real device).
For now, I still use 3.13.4 for that.

A .6 was released a few minutes ago, I don't know if it fixes yet the regression

[g123k]

Flutter 3.13.6 is still KO for iOS and Google has closed the bug -_-
So instead of being blocked by a hypothetical fix, I suggest migrating to 3.13.4

[monsieurtanuki]

Flutter 3.13.6 is still KO for iOS and Google has closed the bug -_-

What about reopening the bug or creating a new one? We may not be the only project that needs to test on iphones?

[g123k]

Flutter 3.13.6 is still KO for iOS and Google has closed the bug -_-

What about reopening the bug or creating a new one? We may not be the only project that needs to test on iphones?

I don't really understand, but I was trying to get the error message to post it here… and now with 3.13.6… it works.
So I will update the PR to this version

[monsieurtanuki]

I don't really understand, but I was trying to get the error message to post it here… and now with 3.13.6… it works.

Let's hope you made a mistake when you tried initially and that actually there's no error at all.
Other possibility: non systematic error in 3.13.6. Less fun to deal with...

[monsieurtanuki]

I guess we're ready then!

[g123k]

Let's merge this 🚀