Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deep link support for "cgi/product.pl?type=edit&code=XXXX" #4587

Merged
merged 1 commit into from
Aug 22, 2023
Merged

feat: Deep link support for "cgi/product.pl?type=edit&code=XXXX" #4587

merged 1 commit into from
Aug 22, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 21, 2023 •
edited
Loading

Hi everyone,

Here is the implementation to support product edition.
For that, it's required to have both a code and a type=edit with the cgi/product.pl route.

DeepLink.mov

@g123k g123k added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps labels Aug 21, 2023
@g123k g123k requested a review from a team as a code owner August 21, 2023 21:51
@g123k g123k self-assigned this Aug 21, 2023
This was linked to issues Aug 21, 2023
Add deep-link capture for Product Edit (https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=8410182000897) #4177
Closed
Links to edit products: how to deal with it? #4585
Closed
teolemon
teolemon approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. I'm making a note that we should instrument that in Matomo.

@teolemon teolemon merged commit 34ccb26 into openfoodfacts:develop Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@g123k g123k

Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🥫 Product page
Projects
None yet
Milestone
No milestone
2 participants
@g123k @teolemon