Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4551 - minor cosmetic changes on settings display #4589

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files

  • app_en.arb: new "join the skill pool" label
  • user_preferences_connect.dart: added dividers; changed the newsletter icon; same email icon everywhere
  • user_preferences_contribute.dart: added "contribute" and a "join the pool" items; minor refactoring
  • user_preferences_faq.dart: changed the "feedback" icon

Screenshot

faq (new feedback icon) contribute (2 new items)
Screenshot_2023-08-22-12-48-47 Screenshot_2023-08-22-12-47-20
connect (top) connect (bottom)
Screenshot_2023-08-22-12-49-19 Screenshot_2023-08-22-12-49-04

Fixes bug(s)

Part of

Impacted files:
* `app_en.arb`: new "join the skill pool" label
* `user_preferences_connect.dart`: added dividers; changed the newsletter icon; same email icon everywhere
* `user_preferences_contribute.dart`: added "contribute" and a "join the pool" items; minor refactoring
* `user_preferences_faq.dart`: changed the "feedback" icon
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 10.32%. Comparing base (e945b38) to head (bff69f1).
Report is 573 commits behind head on develop.

Files with missing lines Patch % Lines
...pages/preferences/user_preferences_contribute.dart 46.66% 8 Missing ⚠️
...pp/lib/pages/preferences/user_preferences_faq.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4589      +/-   ##
===========================================
+ Coverage    10.30%   10.32%   +0.02%     
===========================================
  Files          296      296              
  Lines        15403    15410       +7     
===========================================
+ Hits          1587     1591       +4     
- Misses       13816    13819       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

_getListTile(
title: appLocalizations.contact_title_newsletter,
url: 'https://link.openfoodfacts.org/newsletter-en',
leadingIconData: Icons.subscriptions_outlined,
leadingIconData: CupertinoIcons.news_solid,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also use it for contact_title_press_page ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also use it for contact_title_press_page ?

Done

@teolemon
Copy link
Member

image
for the newsletter
image
for simple email

@monsieurtanuki
Copy link
Contributor Author

"Stacked email" is not a flutter icon :(
Is that because we don't use material 3? Is that because we don't use the latest version of flutter? I don't know.
Please note the difference between https://fonts.google.com/icons?icon.query=email&icon.platform=web&icon.set=Material+Icons and https://fonts.google.com/icons?icon.query=email&icon.platform=web&icon.set=Material+Symbols
We can export/import it as svg if needed, though.

@teolemon
Copy link
Member

  • can you reduce the size of nutrient levels
  • I've noticed a material icon for newspaper, aptly named newspaper. Is it the one we use for blog ?

@monsieurtanuki
Copy link
Contributor Author

  • I've noticed a material icon for newspaper, aptly named newspaper. Is it the one we use for blog ?

Indeed it is.

  • can you reduce the size of nutrient levels

Just have in the latest push.

@monsieurtanuki monsieurtanuki merged commit 8193cf1 into openfoodfacts:develop Aug 22, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

#4580 is almost completely done too; I'll let you close it or fix the wordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to join the skill pool
3 participants