-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't rely on removeDiacritics
to highlight text
#4636
Merged
teolemon
merged 9 commits into
openfoodfacts:develop
from
g123k:suggestion_crash_diatric
Dec 16, 2023
Merged
fix: Don't rely on removeDiacritics
to highlight text
#4636
teolemon
merged 9 commits into
openfoodfacts:develop
from
g123k:suggestion_crash_diatric
Dec 16, 2023
Commits on Dec 8, 2023
-
When we highlight a suggestion, we can't rely on the `removeDiacritic…
…s`, as it replaces some letters of 1 word into 2 or +
Configuration menu - View commit details
-
Copy full SHA for 72f6d5a - Browse repository at this point
Copy the full SHA 72f6d5aView commit details
Commits on Dec 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7af2c89 - Browse repository at this point
Copy the full SHA 7af2c89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a775a6 - Browse repository at this point
Copy the full SHA 6a775a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8fddda - Browse repository at this point
Copy the full SHA a8fdddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for daecba1 - Browse repository at this point
Copy the full SHA daecba1View commit details
Commits on Dec 11, 2023
-
Replace all
toLowerCase
+removeDiacritics
by a single `getCompar……isonSafeString`
Configuration menu - View commit details
-
Copy full SHA for 23caf4f - Browse repository at this point
Copy the full SHA 23caf4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d29e34e - Browse repository at this point
Copy the full SHA d29e34eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2cb4aa - Browse repository at this point
Copy the full SHA a2cb4aaView commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b963ca2 - Browse repository at this point
Copy the full SHA b963ca2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.