feat: 4628 - refactoring as preparatory work

[monsieurtanuki]

What

• The issue demands some understanding of the knowledge panels, and for that I had to delve into the code.
• En passant I refactored a bit the code.
• Now we have a clearer code and I have clearer thoughts about knowledge panels!
• The next step is to actually reorder the knowledge panels according to the user choice (with a reorderable list view). Not really a technical problem, but that's not part of the current PR.

Part of

• For you: allow selecting personal values from knowledge panels #4628

Files

Deleted files:

• knowledge_panel_element_card.dart
• knowledge_panel_summary_card.dart

New files:

• knowledge_panel_image_card.dart: Card that displays a Knowledge Panel Image element.
• knowledge_panel_text_card.dart: Card that displays a Knowledge Panel Text element.
• website_card.dart: Card that displays a website link. Code used to be inside new_product_page.dart

Impacted files:

• knowledge_panel_card.dart: minor refactoring
• knowledge_panel_expanded_card.dart: minor refactoring
• knowledge_panel_page.dart: minor refactoring
• knowledge_panel_page_template.dart: minor refactoring
• knowledge_panels_builder.dart: moved code here from knowledge_panel_element_card.dart and knowledge_panel_summary_card.dart; minor refactoring
• new_product_page.dart: moved the WebsiteCard code to a dedicated file; minor refactoring
• product_cards_helper.dart: minor refactoring
• summary_card.dart: minor refactoring

[codecov-commenter]

Codecov Report

Merging #4641 (4d2d9bd) into develop (2d90250) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop   #4641   +/-   ##
=======================================
  Coverage     9.90%   9.90%           
=======================================
  Files          310     311    +1     
  Lines        15807   15796   -11     
=======================================
- Hits          1566    1565    -1     
+ Misses       14241   14231   -10     

Files	Coverage Δ
...e_panel/knowledge_panels/knowledge_panel_page.dart	0.00% <0.00%> (ø)
...ages/onboarding/knowledge_panel_page_template.dart	0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart	0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart	0.00% <0.00%> (-0.47%)	⬇️
...s/smooth_app/lib/helpers/product_cards_helper.dart	0.00% <0.00%> (ø)
...l/knowledge_panels/knowledge_panel_image_card.dart	0.00% <0.00%> (ø)
...nowledge_panels/knowledge_panel_expanded_card.dart	0.00% <0.00%> (ø)
...e_panel/knowledge_panels/knowledge_panel_card.dart	0.00% <0.00%> (ø)
...el/knowledge_panels/knowledge_panel_text_card.dart	0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/website_card.dart	0.00% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[g123k]

Just some minor comments

[g123k]

That http is bothering me, what are your thoughts on switching to https?

[monsieurtanuki]

Just some minor comments

Hi @g123k!
Your minor comments are on parts of the code I did not write, but only moved during this refactoring.
I cannot go back to details of old code for minor comments, based on "wouldn't it be slightly better if" assumptions.
Especially with my limited time / access to a computer.
The best I can do is add TODOs.

[monsieurtanuki]

@g123k I've just added TODOs for the minor remarks you wrote during your first review.

[monsieurtanuki]

Thank you @g123k for your review!