Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the email variant of the virtual keyboard for the login page #4712

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 16, 2023

Hi everyone,

This issue was only noticed on iOS, but on the login form we ask for a username or an email address, but by default the iOS keyboard won't show the @ sign.

It will fix #4711

@g123k g123k requested a review from a team as a code owner October 16, 2023 08:27
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label Oct 16, 2023
@sweep-ai
Copy link

sweep-ai bot commented Oct 16, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@g123k
Copy link
Collaborator Author

g123k commented Oct 24, 2023

Thanks for your review @monsieurtanuki

@g123k g123k merged commit 2d90250 into openfoodfacts:develop Oct 24, 2023
6 checks passed
@g123k g123k deleted the login_form_email branch October 24, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On iOS, the keyboard doesn't allow typing the "@" character
2 participants