chore: old TODOs #4758
Merged
chore: old TODOs #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `dao_hive_product.dart`: we don't store products in hive since 18 months ago * `dao_unzipped_product.dart`: we don't store products as unzipped since 18 months ago Impacted files: * `background_task_hunger_games.dart`: impacted by off-dart new features * `background_task_image.dart`: impacted by off-dart new features * `crop_page.dart`: impacted by off-dart new features * `local_database.dart`: removed hive and unzipped products
Codecov Report
@@ Coverage Diff @@
## develop #4758 +/- ##
==========================================
+ Coverage 9.83% 9.90% +0.06%
==========================================
Files 313 311 -2
Lines 15905 15808 -97
==========================================
Hits 1565 1565
+ Misses 14340 14243 -97
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
LGTM, thanks @monsieurtanuki
I should take a look at mine eventually as well
|
Thank you @M123-dev for your review! It was not a priority, it's just that I had stumbled into those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TODOsFiles
Deleted files:
dao_hive_product.dart: we don't store products in hive since 18 months agodao_unzipped_product.dart: we don't store products as unzipped since 18 months agoImpacted files:
background_task_hunger_games.dart: impacted by off-dart new featuresbackground_task_image.dart: impacted by off-dart new featurescrop_page.dart: impacted by off-dart new featureslocal_database.dart: removed hive and unzipped products