Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (Re)Use the public version of mobile_scanner #4765

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 4, 2023

Hi everyone,

A blocking crash on iOS was forcing us to use a forked version of mobile_scanner.
But it's now OK to use back the version, as it's fixed (actually it's also a revert of the faulty code)

Will fix #4753 4753

@g123k g123k self-assigned this Nov 4, 2023
@g123k g123k requested a review from a team as a code owner November 4, 2023 15:12
@github-actions github-actions bot added 🍎 iOS iOS specific issues or PRs dependencies labels Nov 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4765 (3b04dac) into develop (21469af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #4765   +/-   ##
=======================================
  Coverage     9.89%   9.89%           
=======================================
  Files          312     312           
  Lines        15809   15809           
=======================================
  Hits          1565    1565           
  Misses       14244   14244           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@teolemon teolemon merged commit c28f8d2 into openfoodfacts:develop Nov 6, 2023
6 checks passed
@teolemon
Copy link
Member

teolemon commented Nov 6, 2023

thanks @g123k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🍎 iOS iOS specific issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We can update the scanner (new version available)
4 participants