Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgraded app_settings to 5.1.1 #4816

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Upgraded package app_settings to version 5.1.1, with minor refactoring needed.

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0ddd5c6) 9.90% compared to head (0ee7c1a) 9.89%.
Report is 2 commits behind head on develop.

Files Patch % Lines
packages/smooth_app/lib/pages/image_crop_page.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4816      +/-   ##
==========================================
- Coverage     9.90%   9.89%   -0.01%     
==========================================
  Files          310     311       +1     
  Lines        15759   15784      +25     
==========================================
+ Hits          1561    1562       +1     
- Misses       14198   14222      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me 👍

@teolemon teolemon merged commit 40f4c0e into openfoodfacts:develop Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants