fix: 4807 - putting back a useless hive table, just in case

[monsieurtanuki]

What

• Added back a table we don't use anymore, so that hive (hopefully) does not complain.

Part of

• HiveError: Adapter not registered? #4807

[teolemon]

Small formatting issue
Run dart format --set-exit-if-changed .
Formatted packages/smooth_app/lib/database/dao_hive_product.dart
Formatted 381 files (1 changed) in 1.55 seconds.
Error: Process completed with exit code 1.

[codecov-commenter]

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (6e0034b) 9.89% compared to head (e12ca41) 9.87%.

Files	Patch %	Lines
...ages/smooth_app/lib/database/dao_hive_product.dart	0.00%	32 Missing ⚠️
...ckages/smooth_app/lib/database/local_database.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #4821      +/-   ##
==========================================
- Coverage     9.89%   9.87%   -0.03%     
==========================================
  Files          311     312       +1     
  Lines        15787   15820      +33     
==========================================
  Hits          1562    1562              
- Misses       14225   14258      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[monsieurtanuki]

Small formatting issue Run dart format --set-exit-if-changed . Formatted

When it rains, it pours. I tried a new version of Android Studio in order to fix the gradle BS so that I can build the release APK. And in this AS version the formatting is not automatic.
In addition to that the emulators do not work anymore, so I'm currently going back to the previous AS version. Otherwise I had a very nice day.

[monsieurtanuki]

I would be very glad if it worked 🤞 , but there's something really fishy given that the (edit: faulty) PR is not supposed to be part of 4.11.0.

[g123k]

I think it should work now.
When the release is fine again, I think we can replace this code by a dummy Adapter, which does basically nothing.
Hive is only expecting an Adapter, not the code to serialize/deserialize the content.

[monsieurtanuki]

I think it should work now.

I would be very happy if it's successful!
But I would need an explanation: how come a PR that is supposed to be on unreleased 4.12.0 ends up on 4.11?
In addition to that, I would open an issue at hive - but that's another story.

[M123-dev]

But I would need an explanation: how come a PR that is supposed to be on unreleased 4.12.0 ends up on 4.11?

As you've correctly said 4.12.0 is unreleased @monsieurtanuki .

But the PR is just a front for a release. The release Action is called from multiple sources

• Up until half a year ago on every commit (version code +1)
• Manually, somewhere in Github.com cant say exactly where (version code +1)
• Merging the release pull request (version name and version code upgrade, triggers a new F-Droid build)

All of them build and upload an APK.

Meaning versions which are supposed to be publicly released under 4.12 can be on the n'th 4.11 already when manually triggered.

Useful for testing but not to keep track of changes.

Maybe we should make sure that only the release-please versions are pushed to beta or production. Meaning only the first of a certain version name. But that's up to @teolemon

[teolemon]

• I did a manual release using Release.md this week, before the removal of the data migrator. I did not do a staged release as I usually do.
• I was under the false impression that It was working well/I had tested it in internal/Nobody had issues, while my local build was probably weeks old.