Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Customized language picker UI for the onboarding #4826

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 20, 2023

Hi everyone,

I've tweaked a little bit the UI of the language picker in the onboarding.
It won't stay with the redesigned one, so it's just some minor fixes:

  • An edit button, instead of a chevron (it's not a dropdown)
  • Really weird paddings
  • Same UI as the search bar in the redesign.

The UI is OK both in dark/light modes + the widget used in the preferences is still OK.
I've also checked the a11n is OK.

Some screenshots:
Current UI:
Screenshot 2023-11-20 at 02 28 27

New UI:
Screenshot 2023-11-20 at 02 56 11
Screenshot 2023-11-20 at 02 56 27

@g123k g123k added 🎨 UI / UX 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Nov 20, 2023
@g123k g123k requested a review from a team as a code owner November 20, 2023 02:04
@g123k g123k linked an issue Nov 20, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (f145c3c) 9.87% compared to head (4f9e308) 9.85%.

Files Patch % Lines
...oth_app/lib/pages/onboarding/country_selector.dart 0.00% 19 Missing ⚠️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4826      +/-   ##
==========================================
- Coverage     9.87%   9.85%   -0.02%     
==========================================
  Files          312     312              
  Lines        15820   15839      +19     
==========================================
- Hits          1562    1561       -1     
- Misses       14258   14278      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better 👍

@teolemon teolemon merged commit d3c25f2 into openfoodfacts:develop Nov 21, 2023
7 checks passed
@g123k g123k deleted the onboarding_langage_picker branch November 25, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 l10n 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎨 UI / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The border around the language picker is incorrect
3 participants