fix: 4853 - new "dist" subfolder for server attribute images

[monsieurtanuki]

What

Changed https://static.openfoodfacts.org/images/attributes/ into https://static.openfoodfacts.org/images/attributes/dist/

Fixes bug(s)

• Fixes: fix the current hard-coded https://static.openfoodfacts.org/images/ URLs #4853

Part of

• fix: If there is a network error in an SVG file, we should consider it as an error #4850

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5eb9db7) 9.87% compared to head (07ddb3f) 9.78%.
Report is 11 commits behind head on develop.

Files	Patch %	Lines
...app/lib/pages/product/product_incomplete_card.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #4854      +/-   ##
==========================================
- Coverage     9.87%   9.78%   -0.10%     
==========================================
  Files          312     313       +1     
  Lines        15820   15957     +137     
==========================================
- Hits          1562    1561       -1     
- Misses       14258   14396     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[teolemon]

Is there a way to factorize all of this ?

[monsieurtanuki]

Is there a way to factorize all of this ?

@teolemon In this PR there are 2 dart files, where we can use a const in order to share the same image root url.

There are also 2 json asset files.
One of them we won't need anymore: it's the onboarding "best product", to be deprecated with the new onboarding.
The other one is the default attribute list in English, when we cannot reach the server at onboarding/language time. I think we'll still need that file. Less immediate to refactor cleanly.

Thanks to @g123k's recent PR from now on we don't really care about wrong URLs of files we already have in assets.
Would be different for new files.

Please create a new issue if needed.