feat: 4947 - added "download language" to product table #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted file: * `dao_product_migration.dart` Impacted files: * `background_task_download_products.dart`: added language parameter * `dao_hive_product.dart`: removed dead code * `dao_product.dart`: added table column language `lc` * `local_database.dart`: upgraded the database version * `onboarding_data_product.dart`: added language parameter * `product_list_page.dart`: added language parameter * `product_refresher.dart`: added language parameter * `query_product_list_supplier.dart`: added language parameter
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4951 +/- ##
==========================================
+ Coverage 9.65% 9.66% +0.01%
==========================================
Files 323 322 -1
Lines 16207 16175 -32
==========================================
Hits 1564 1564
+ Misses 14643 14611 -32 ☔ View full report in Codecov by Sentry. |
M123-dev
approved these changes
Jan 7, 2024
Comment on lines
-38
to
-81
|
|
||
| LazyBox<Product> _getBox() => Hive.lazyBox<Product>(_hiveBoxName); | ||
|
|
||
| Future<Product?> get(final String barcode) async => _getBox().get(barcode); | ||
|
|
||
| @override | ||
| Future<Map<String, Product>> getAll(final List<String> barcodes) async { | ||
| final LazyBox<Product> box = _getBox(); | ||
| final Map<String, Product> result = <String, Product>{}; | ||
| for (final String barcode in barcodes) { | ||
| final Product? product = await box.get(barcode); | ||
| if (product != null) { | ||
| result[barcode] = product; | ||
| } | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| Future<void> put(final Product product) async => putAll(<Product>[product]); | ||
|
|
||
| Future<void> putAll(final Iterable<Product> products) async { | ||
| final Map<String, Product> upserts = <String, Product>{}; | ||
| for (final Product product in products) { | ||
| upserts[product.barcode!] = product; | ||
| } | ||
| await _getBox().putAll(upserts); | ||
| } | ||
|
|
||
| @override | ||
| Future<List<String>> getAllKeys() async { | ||
| final LazyBox<Product> box = _getBox(); | ||
| final List<String> result = <String>[]; | ||
| for (final dynamic key in box.keys) { | ||
| result.add(key.toString()); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| // Just for the migration | ||
| @override | ||
| Future<void> deleteAll(final List<String> barcodes) async { | ||
| final LazyBox<Product> box = _getBox(); | ||
| await box.deleteAll(barcodes); | ||
| } |
There was a problem hiding this comment.
Did you test if this part removal will work or also break the whole app, nontheless we should keep an eye out in the beta
|
Thank you @M123-dev for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of
Files
Deleted file:
dao_product_migration.dartImpacted files:
background_task_download_products.dart: added language parameterdao_hive_product.dart: removed dead codedao_product.dart: added table column languagelclocal_database.dart: upgraded the database versiononboarding_data_product.dart: added language parameterproduct_list_page.dart: added language parameterproduct_refresher.dart: added language parameterquery_product_list_supplier.dart: added language parameter