Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4973 - "shortcut to prices app" button controlled by dev mode #4976

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • New "shortcut to prices app" flag in dev mode.
  • Related new "shortcut to prices app" button in product page.

Screenshots

dev mode flag product page prices app
Screenshot_1705068993 Screenshot_1705069031 Screenshot_1705069273

Fixes bug(s)

Impacted files

  • app_en.arb: added 2 "prices app" labels; removed old labels
  • new_product_page.dart: added a dev mode controlled "shortcut to prices app" button
  • plural_translation_test.dart: removed a test about an old label
  • pubspec.lock: wtf
  • user_preferences_dev_mode.dart: added a dev mode "shortcut to prices app" flag

Impacted files:
* `app_en.arb`: added 2 "prices app" labels; removed old labels
* `new_product_page.dart`: added a dev mode controlled "shortcut to prices app" button
* `plural_translation_test.dart`: removed a test about an old label
* `pubspec.lock`: wtf
* `user_preferences_dev_mode.dart`: added a dev mode "shortcut to prices app" flag
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner January 12, 2024 14:37
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🧪 Tests labels Jan 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (85784fa) 9.62% compared to head (47ed3bf) 9.61%.

Files Patch % Lines
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% 6 Missing ⚠️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4976      +/-   ##
==========================================
- Coverage     9.62%   9.61%   -0.01%     
==========================================
  Files          323     323              
  Lines        16267   16279      +12     
==========================================
  Hits          1565    1565              
- Misses       14702   14714      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell 👍

@monsieurtanuki monsieurtanuki merged commit 5f72b28 into openfoodfacts:develop Jan 12, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🧪 Tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a simple DEV mode button to go to jump between the product page and its Open Prices equivalent
3 participants