-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 5102 - fixed the path of the database to backup #5103
Conversation
cc @linsui |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5103 +/- ##
==========================================
- Coverage 9.54% 9.53% -0.02%
==========================================
Files 325 327 +2
Lines 16411 16529 +118
==========================================
+ Hits 1567 1576 +9
- Misses 14844 14953 +109 ☔ View full report in Codecov by Sentry. |
https://gitlab.com/linsui/fdroiddata/-/jobs/6305195522 It works, thanks! |
@linsui Cool! |
What
Subdirectories are not allowed for domain database
domain
parameter specifies the (allowed? impliciit?) directoriesFor the record (1) the database folder created by our app is
databases/
(as returnedgetDatabasesPath()
).Does that mean that we should put
databases/smoothie.db
, or justsmoothie.db
? Let's try, it's either with or without explicitly mentioningdatabases/
.For the record (2) the amount of backed-up data is limited to 25 Mb. Which means that we would probably be better off NOT including the sqflite database (which is meant to grow far beyond 25 Mb), so that the rest of the data can be backed up. Then comes the question: how to make sense of lists of barcodes if we don't have locally the matching products?
Fixes bug(s)