fix: 5102 - fixed the path of the database to backup #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @linsui |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5103 +/- ##
==========================================
- Coverage 9.54% 9.53% -0.02%
==========================================
Files 325 327 +2
Lines 16411 16529 +118
==========================================
+ Hits 1567 1576 +9
- Misses 14844 14953 +109 ☔ View full report in Codecov by Sentry. |
|
https://gitlab.com/linsui/fdroiddata/-/jobs/6305195522 It works, thanks! |
@linsui Cool! |
teolemon
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Subdirectories are not allowed for domain databasedomainparameter specifies the (allowed? impliciit?) directoriesFor the record (1) the database folder created by our app is
databases/(as returnedgetDatabasesPath()).Does that mean that we should put
databases/smoothie.db, or justsmoothie.db? Let's try, it's either with or without explicitly mentioningdatabases/.For the record (2) the amount of backed-up data is limited to 25 Mb. Which means that we would probably be better off NOT including the sqflite database (which is meant to grow far beyond 25 Mb), so that the rest of the data can be backed up. Then comes the question: how to make sense of lists of barcodes if we don't have locally the matching products?
Fixes bug(s)