-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 5145 - bold style for unknown ingredients in KP #5149
Conversation
Impacted files: * `pubspec.lock`: wtf * `pubspec.yaml`: added a needed dependency to `html` (already implicitly there anyway because of `flutter_widget_from_html_core`) * `smooth_html_widget.dart`: specific "bold" effect for css class name `unknown_ingredient`
@jusdekiwi ping |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5149 +/- ##
==========================================
- Coverage 9.54% 9.51% -0.03%
==========================================
Files 325 327 +2
Lines 16411 16557 +146
==========================================
+ Hits 1567 1576 +9
- Misses 14844 14981 +137 ☔ View full report in Codecov by Sentry. |
That would be very useful!!! Will it work for dark mode as well? |
@jusdekiwi It works in dark mode too: |
amazing! Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve. My slight concern is that this could be mistaken for an allergen, but worst case scenario, we change the name of the class, and it all disappears.
Thank you @teolemon @jusdekiwi for your review and comments!
Indeed, but "bold" was the initial requirement. Which other CSS style would you suggest?
Indeed. The only solution would be for the server to provide the KP with an inline css, assuming that we're able to interpret it in flutter. |
What
<span>raisins secs</span>
<span class=\"text_info unknown_ingredient\">raisins de sultane</span>
Screenshots
Example on "raisins de sultane" for 5010477348678.
Fixes bug(s)
Impacted files
pubspec.lock
: wtfpubspec.yaml
: added a needed dependency tohtml
(already implicitly there anyway because offlutter_widget_from_html_core
)smooth_html_widget.dart
: specific "bold" effect for css class nameunknown_ingredient