Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Knowledge Panel details page accessibility improvements #5290

Merged
merged 2 commits into from
May 25, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 25, 2024

Hi everyone,

Here are my accessibility changes:

  • The title is now "Details for XXX with YYY" (XXX is the name of the section and YYY the product name)
  • Positive and negative points are not merged in the full-page
  • The Nutri-Score card is not considered as a button within the page

Unfortunately, I can't fix "-> Button" (cf #5289), because it's some HTML provided by the server.

Untitled.mp4

@g123k g123k self-assigned this May 25, 2024
@g123k g123k requested a review from a team as a code owner May 25, 2024 07:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 8.16%. Comparing base (4d9c7fc) to head (64ae73c).
Report is 134 commits behind head on develop.

Files Patch % Lines
...e_panel/knowledge_panels/knowledge_panel_page.dart 0.00% 12 Missing ⚠️
...es/smooth_app/lib/cards/data_cards/score_card.dart 0.00% 6 Missing ⚠️
...l/knowledge_panels/knowledge_panel_group_card.dart 0.00% 4 Missing ⚠️
...el/knowledge_panels/knowledge_panel_text_card.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5290      +/-   ##
==========================================
- Coverage     9.54%   8.16%   -1.39%     
==========================================
  Files          325     356      +31     
  Lines        16411   17980    +1569     
==========================================
- Hits          1567    1468      -99     
- Misses       14844   16512    +1668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 44e4774 into openfoodfacts:develop May 25, 2024
6 checks passed
@g123k g123k deleted the a11_kp branch May 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants