Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5205 - added a "My prices" item linking to the web app #5317

Merged
merged 2 commits into from
May 31, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added a "My prices" item linking to the web app

Screenshot

Screenshot_1717157440

Part of

Impacted files

  • app_en.arb: added a "My prices" label
  • app_fr.arb: added a "My prices" label
  • user_preferences_account.dart: added a "My prices" item

Impacted files:
* `app_en.arb`: added a "My prices" label
* `app_fr.arb`: added a "My prices" label
* `user_preferences_account.dart`: added a "My prices" item
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 7.65%. Comparing base (4d9c7fc) to head (30762de).
Report is 156 commits behind head on develop.

Files Patch % Lines
...ib/pages/preferences/user_preferences_account.dart 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5317      +/-   ##
==========================================
- Coverage     9.54%   7.65%   -1.90%     
==========================================
  Files          325     370      +45     
  Lines        16411   18686    +2275     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17256    +2412     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @monsieurtanuki 👍

@teolemon
Copy link
Member

teolemon commented May 31, 2024

Can you possibly add "Latest Prices added" >> https://prices.openfoodfacts.org/app/prices @monsieurtanuki
"Top price contributors" >> https://prices.openfoodfacts.org/app/users
"Stores with the most prices" >> https://prices.openfoodfacts.org/app/locations
"Products with the most prices" >> https://prices.openfoodfacts.org/app/products

@monsieurtanuki monsieurtanuki merged commit 722c2f4 into openfoodfacts:develop May 31, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Can you possibly add "Latest Prices added", "Top price contributors", "Stores with the most prices", "Products with the most prices"

I could, but I don't know where. After "My prices"? That would be a bit in bulk. Would there be a better place, existing or to be created? Tell me what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants