Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5345 #5346

Merged
merged 2 commits into from
Jun 8, 2024
Merged

fix: 5345 #5346

merged 2 commits into from
Jun 8, 2024

Conversation

monsieurtanuki
Copy link
Contributor

No description provided.

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 8, 2024 12:26
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label Jun 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 7.58%. Comparing base (4d9c7fc) to head (8316a1b).
Report is 168 commits behind head on develop.

Files Patch % Lines
...th_app/lib/pages/user_management/sign_up_page.dart 0.00% 2 Missing ⚠️
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5346      +/-   ##
==========================================
- Coverage     9.54%   7.58%   -1.97%     
==========================================
  Files          325     373      +48     
  Lines        16411   18862    +2451     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17432    +2588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange to see a PR from you without a very descriptive message, still good to go 👍🏻

@monsieurtanuki monsieurtanuki linked an issue Jun 8, 2024 that may be closed by this pull request
@monsieurtanuki monsieurtanuki merged commit 2dd4575 into openfoodfacts:develop Jun 8, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your quick review!

Strange to see a PR from you without a very descriptive message, still good to go 👍🏻

Indeed, I was a bit angry about this issue! And I had to rush too, the Roland Garros women's final is starting 🎾

@M123-dev
Copy link
Member

M123-dev commented Jun 8, 2024

Ohh have fun watching @monsieurtanuki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 User management Account login, signup, signout
Development

Successfully merging this pull request may close these issues.

Changes blocking the CI
3 participants