Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename tagline* to AppNews #5377

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 15, 2024

Hi everyone!

I want to re-introduce the app review on the homepage and also the ability to inject custom info (e.g.: new country detected…).

So, now the TagLine becomes AppNews.
And the current TagLine refers to the content below the search card on the homepage.

In terms of code, there's just some renaming + some files moved:
Screenshot 2024-06-15 at 12 01 14

@g123k g123k requested a review from a team as a code owner June 15, 2024 10:06
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… GitHub 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… product scan carousel User lists labels Jun 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 2.55319% with 229 lines in your changes missing coverage. Please review.

Project coverage is 7.38%. Comparing base (4d9c7fc) to head (e9eae22).
Report is 190 commits behind head on develop.

Files Patch % Lines
...oth_app/lib/pages/scan/carousel/scan_carousel.dart 0.00% 84 Missing ⚠️
.../pages/scan/carousel/main_card/scan_main_card.dart 5.88% 48 Missing ⚠️
...p/lib/data_models/news_feed/newsfeed_provider.dart 10.00% 27 Missing ⚠️
...ib/pages/scan/carousel/main_card/scan_tagline.dart 0.00% 21 Missing ⚠️
...h_app/lib/data_models/news_feed/newsfeed_json.dart 0.00% 16 Missing ⚠️
..._app/lib/data_models/news_feed/newsfeed_model.dart 0.00% 15 Missing ⚠️
...lib/pages/scan/carousel/scan_carousel_manager.dart 0.00% 6 Missing ⚠️
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 3 Missing ⚠️
packages/smooth_app/lib/main.dart 0.00% 2 Missing ⚠️
...e_panel/knowledge_panels/knowledge_panel_page.dart 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5377      +/-   ##
==========================================
- Coverage     9.54%   7.38%   -2.17%     
==========================================
  Files          325     385      +60     
  Lines        16411   19629    +3218     
==========================================
- Hits          1567    1449     -118     
- Misses       14844   18180    +3336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit a3e9bc2 into openfoodfacts:develop Jun 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page product scan carousel 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… User lists
Development

Successfully merging this pull request may close these issues.

3 participants