Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edge to edge mode on Android #5378

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 15, 2024

Hi everyone!

Now, we have the same behavior between Android and iOS with an edge-to-edge mode.
Screenshot_1718455771
Screenshot_1718455827

@g123k g123k self-assigned this Jun 15, 2024
@g123k g123k requested a review from a team as a code owner June 15, 2024 13:10
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 📈 Analytics We use Sentry and Matomo, with an opt-in system labels Jun 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.37931% with 143 lines in your changes missing coverage. Please review.

Project coverage is 7.38%. Comparing base (4d9c7fc) to head (5ec11a2).
Report is 191 commits behind head on develop.

Files Patch % Lines
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% 45 Missing ⚠️
...oth_app/lib/pages/onboarding/permissions_page.dart 0.00% 28 Missing ⚠️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% 24 Missing ⚠️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% 22 Missing ⚠️
...es/smooth_app/lib/pages/product/edit_ocr_page.dart 0.00% 13 Missing ⚠️
packages/smooth_app/lib/main.dart 0.00% 5 Missing ⚠️
...ckages/smooth_app/lib/widgets/smooth_scaffold.dart 50.00% 2 Missing ⚠️
...ages/onboarding/knowledge_panel_page_template.dart 0.00% 1 Missing ⚠️
...oth_app/lib/pages/onboarding/reinvention_page.dart 0.00% 1 Missing ⚠️
...mooth_app/lib/pages/product/edit_product_page.dart 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5378      +/-   ##
==========================================
- Coverage     9.54%   7.38%   -2.17%     
==========================================
  Files          325     384      +59     
  Lines        16411   19646    +3235     
==========================================
- Hits          1567    1451     -116     
- Misses       14844   18195    +3351     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell @g123k 🤩

@teolemon teolemon merged commit 2a08ab4 into openfoodfacts:develop Jun 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system Android 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… OS integrations Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Development

Successfully merging this pull request may close these issues.

3 participants