-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prices - barcode reader for additional products #5381
feat: prices - barcode reader for additional products #5381
Conversation
New file: * `price_scan_page.dart`: Page showing the camera feed and decoding the first barcode, for Prices. Impacted files: * `app_en.arb`: added 1 "barcode reader" label * `app_fr.arb`: added 1 "barcode reader" label * `camera_scan_page.dart`: minor refactoring * `price_product_search_page.dart`: added a FAB towards the new barcode reader page
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5381 +/- ##
==========================================
- Coverage 9.54% 7.37% -2.18%
==========================================
Files 325 385 +60
Lines 16411 19667 +3256
==========================================
- Hits 1567 1450 -117
- Misses 14844 18217 +3373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried the initial support yesterday, I tried to click on the little barcode. Will it work ? Not sure a bottom right fab will be the most intuitive
The point of the little barcode is to say that it's a barcode input, not a text input. |
I would have also made the little barcode clickable but I can survive. |
Thank you @teolemon for your review and feedbacks! Anyway now that the barcode reader feature is there, we may change the UI/UX when needed. |
What
Screenshots
Files
New file:
price_scan_page.dart
: Page showing the camera feed and decoding the first barcode, for Prices.Impacted files:
app_en.arb
: added 1 "barcode reader" labelapp_fr.arb
: added 1 "barcode reader" labelcamera_scan_page.dart
: minor refactoringprice_product_search_page.dart
: added a FAB towards the new barcode reader page