Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboarding with main/home page from the POC #5382

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 15, 2024

Hi everyone!

Instead of wishing a happy birthday to OFF two years later, I've imported the code from the POC 😅
Screenshot_1718463878

@g123k g123k added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… ✨ 2024 the big redesign labels Jun 15, 2024
@g123k g123k self-assigned this Jun 15, 2024
@g123k g123k requested a review from a team as a code owner June 15, 2024 15:08
@g123k g123k linked an issue Jun 15, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 2.00000% with 147 lines in your changes missing coverage. Please review.

Project coverage is 7.35%. Comparing base (4d9c7fc) to head (cfb3cb2).
Report is 193 commits behind head on develop.

Files Patch % Lines
...oth_app/lib/pages/onboarding/reinvention_page.dart 3.06% 95 Missing ⚠️
...b/pages/onboarding/v2/onboarding_bottom_hills.dart 0.00% 41 Missing ⚠️
packages/smooth_app/lib/widgets/smooth_text.dart 0.00% 8 Missing ⚠️
...ib/pages/onboarding/onboarding_flow_navigator.dart 0.00% 2 Missing ⚠️
.../smooth_app/lib/data_models/onboarding_loader.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5382      +/-   ##
==========================================
- Coverage     9.54%   7.35%   -2.20%     
==========================================
  Files          325     386      +61     
  Lines        16411   19773    +3362     
==========================================
- Hits          1567    1454     -113     
- Misses       14844   18319    +3475     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we're leaving out the pioneer aspect and the experience message (we've been in business for 10 years), but I can cope

@g123k
Copy link
Collaborator Author

g123k commented Jun 15, 2024

I feel we're leaving out the pioneer aspect and the experience message (we've been in business for 10 years), but I can cope

Honestly, as a user, when someone tells me I was the first… I don't care.
What I want instead is that you are NOW the best.

But if you want to change the text, no problem, this is just a translation

@teolemon
Copy link
Member

@g123k small merge conflict

@teolemon teolemon merged commit 3b88ac0 into openfoodfacts:develop Jun 15, 2024
6 checks passed
@teolemon
Copy link
Member

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… ✨ 2024 the big redesign
Development

Successfully merging this pull request may close these issues.

Shouldn't we update the first page of the onboarding?
3 participants