-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prices - top contributors now within the app #5383
feat: prices - top contributors now within the app #5383
Conversation
New files: * `price_user_button.dart`: Widget that displays a user, for Prices. * `prices_users_page.dart`: Page that displays the top prices users. Impacted files: * `app_en.arb`: added 2 label for "Contributor prices" * `app_fr.arb`: added 2 label for "Contributor prices" * `price_count_widget.dart`: minor refactoring * `price_data_widget.dart`: minor refactoring using new class `PriceUserButton` * `user_preferences_account.dart`: local display of top users; minor refactoring using new class `PriceUserButton`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5383 +/- ##
==========================================
- Coverage 9.54% 7.33% -2.22%
==========================================
Files 325 388 +63
Lines 16411 19849 +3438
==========================================
- Hits 1567 1455 -112
- Misses 14844 18394 +3550 ☔ View full report in Codecov by Sentry. |
@monsieurtanuki it might be nice adding a link to photographer, editor, contributor on the main project as well. |
Sure! Please create another issue for that.
Fair enough. |
Thank you @teolemon for your review and your feedbacks! |
What
Screenshots
Fixes bug(s)
Files
New files:
price_user_button.dart
: Widget that displays a user, for Prices.prices_users_page.dart
: Page that displays the top prices users.Impacted files:
app_en.arb
: added 2 label for "Contributor prices"app_fr.arb
: added 2 label for "Contributor prices"price_count_widget.dart
: minor refactoringprice_data_widget.dart
: minor refactoring using new classPriceUserButton
user_preferences_account.dart
: local display of top users; minor refactoring using new classPriceUserButton