chore: "Take a picture" button now distinguishes "Take a picture" VS "Take a new picture"

[g123k]

Hi everyone,

As explained in #5393, the button to take a picture asks for a new photo, which may be confusing.
Now, there's a distinction between "taking the first photo" and "taking a new photo".

Existing picture:

No picture:

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 7.26%. Comparing base (4d9c7fc) to head (e24f4d9).
Report is 200 commits behind head on develop.

Files	Patch %	Lines
...es/smooth_app/lib/pages/product/edit_ocr_page.dart	0.00%	6 Missing ⚠️
...th_app/lib/pages/product/product_image_viewer.dart	0.00%	6 Missing ⚠️
.../lib/pages/product/product_image_local_button.dart	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5396      +/-   ##
==========================================
- Coverage     9.54%   7.26%   -2.29%     
==========================================
  Files          325     391      +66     
  Lines        16411   20034    +3623     
==========================================
- Hits          1567    1456     -111     
- Misses       14844   18578    +3734     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[monsieurtanuki]

Hi @g123k!
It would be much much simpler to just rename the unique label as "Take a new picture". Would always work. No bad interpretation possible. Easier to maintain.

[teolemon]

Thanks @g123k , small merge conflict before merging

[g123k]

Thanks @g123k , small merge conflict before merging

Ok will do.
Do you have an opinion on @monsieurtanuki suggestion?

[teolemon]

• I've been slightly bothered by the new picture thing when none exists. Instructions are more easily followed when specific and unambiguous
• I also want us to encourage photo refresh across off with specific nudges, which is a vital issue to keep the db up to date.

[monsieurtanuki]

I've been slightly bothered by the new picture thing when none exists. Instructions are more easily followed when specific and unambiguous

The less ambiguous is "Take a new picture", in all cases (instead of "take another picture").

• I also want us to encourage photo refresh across off with specific nudges, which is a vital issue to keep the db up to date.

That would deserve a specific issue.