Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow LaunchUrlHelper to follow deep links #5450

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 28, 2024

Hi everyone,

As is, the url_launcher dependency ignores deep links.
To prevent this from happening (and avoid breaking things), there is now a second method redirecting to GoRouter

@g123k g123k requested a review from a team as a code owner June 28, 2024 07:39
@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jun 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.18%. Comparing base (4d9c7fc) to head (05b4e9e).
Report is 232 commits behind head on develop.

Files Patch % Lines
...ages/smooth_app/lib/helpers/launch_url_helper.dart 0.00% 7 Missing ⚠️
...ib/pages/scan/carousel/main_card/scan_tagline.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5450      +/-   ##
==========================================
- Coverage     9.54%   7.18%   -2.37%     
==========================================
  Files          325     391      +66     
  Lines        16411   20388    +3977     
==========================================
- Hits          1567    1464     -103     
- Misses       14844   18924    +4080     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 32cab47 into openfoodfacts:develop Jun 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging this pull request may close these issues.

3 participants