Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spellchecker on product name 5415 #5451

Merged

Conversation

jnnabugwu
Copy link
Contributor

What

Added Spellchecker to product field on basic details page.

Screenshot

Simulator Screenshot - iPhone 14 Pro - 2024-06-30 at 20 48 19

Fixes bug(s)

  • Fixes:

Part of

@g123k
Copy link
Collaborator

g123k commented Jul 1, 2024

Thanks for your PR @jnnabugwu, but as the other one, you have a formatting issue
https://github.com/openfoodfacts/smooth-app/actions/runs/9736442467/job/26867075376?pr=5451

@jnnabugwu jnnabugwu changed the title Spellchecker on product name 5415 feat: Spellchecker on product name 5415 Jul 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 7.18%. Comparing base (4d9c7fc) to head (ff87ede).
Report is 235 commits behind head on develop.

Files Patch % Lines
..._app/lib/pages/product/add_basic_details_page.dart 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5451      +/-   ##
==========================================
- Coverage     9.54%   7.18%   -2.37%     
==========================================
  Files          325     391      +66     
  Lines        16411   20400    +3989     
==========================================
- Hits          1567    1465     -102     
- Misses       14844   18935    +4091     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon teolemon merged commit 1ff9a0a into openfoodfacts:develop Jul 4, 2024
6 of 7 checks passed
@teolemon
Copy link
Member

teolemon commented Jul 4, 2024

thanks @jnnabugwu 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants