Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Flutter version to 3.22 #5458

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 4, 2024

@g123k g123k requested a review from a team as a code owner July 4, 2024 06:38
@github-actions github-actions bot added 📚 Documentation Improvements or additions to documentation dependencies 🤳🥫 ZXing labels Jul 4, 2024
@g123k g123k marked this pull request as draft July 4, 2024 06:45
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be delayed after the release in prod (is that 4.15?).

@g123k g123k marked this pull request as ready for review July 4, 2024 06:56
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 👥 User management Account login, signup, signout ✏️ Editing - Nutrition input 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🖼️ Photos - Cropping User lists Hunger Games ✏️ Editing - 📦 Packaging input OCR page labels Jul 4, 2024
@g123k
Copy link
Collaborator Author

g123k commented Jul 4, 2024

To be delayed after the release in prod (is that 4.15?).

4.15 is already released

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.31818% with 49 lines in your changes missing coverage. Please review.

Project coverage is 7.16%. Comparing base (4d9c7fc) to head (46c37cf).
Report is 235 commits behind head on develop.

Files Patch % Lines
...b/pages/onboarding/v2/onboarding_bottom_hills.dart 0.00% 8 Missing ⚠️
...mooth_app/lib/pages/product/edit_image_button.dart 0.00% 4 Missing ⚠️
packages/smooth_app/lib/themes/smooth_theme.dart 80.00% 4 Missing ⚠️
...pp/lib/pages/onboarding/onboarding_bottom_bar.dart 0.00% 3 Missing ⚠️
...app/lib/pages/product/product_incomplete_card.dart 0.00% 3 Missing ⚠️
.../lib/generic_lib/buttons/smooth_simple_button.dart 60.00% 2 Missing ⚠️
...b/pages/hunger_games/question_answers_options.dart 0.00% 2 Missing ⚠️
packages/smooth_app/lib/pages/image_crop_page.dart 0.00% 2 Missing ⚠️
...h_app/lib/pages/locations/location_query_page.dart 0.00% 2 Missing ⚠️
...ib/pages/preferences/user_preferences_account.dart 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5458      +/-   ##
==========================================
- Coverage     9.54%   7.16%   -2.39%     
==========================================
  Files          325     391      +66     
  Lines        16411   20382    +3971     
==========================================
- Hits          1567    1461     -106     
- Misses       14844   18921    +4077     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 9e211ca into openfoodfacts:develop Jul 4, 2024
6 checks passed
@g123k g123k mentioned this pull request Jul 4, 2024
g123k added a commit that referenced this pull request Jul 4, 2024
@g123k
Copy link
Collaborator Author

g123k commented Jul 4, 2024

PR reverted due to #5462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📚 Documentation Improvements or additions to documentation ✏️ Editing - Nutrition input ✏️ Editing - 📦 Packaging input Hunger Games OCR page 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🖼️ Photos - Cropping Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… User lists 👥 User management Account login, signup, signout 🤳🥫 ZXing
Development

Successfully merging this pull request may close these issues.

4 participants