Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump mobile_scanner to fix a crash on iOS #5464

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 4, 2024

Hi everyone!

We have a severe crash on iOS due to mobile_scanner.
In this PR, the upgrade is limited to the branch 4.x, as it's enough.
5.x requires some work on our part.

Once this PR is merged, we can then release a 4.15.1 (only for iOS devices)

@g123k g123k requested a review from a team as a code owner July 4, 2024 08:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.18%. Comparing base (4d9c7fc) to head (873520c).
Report is 237 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5464      +/-   ##
==========================================
- Coverage     9.54%   7.18%   -2.37%     
==========================================
  Files          325     391      +66     
  Lines        16411   20388    +3977     
==========================================
- Hits          1567    1464     -103     
- Misses       14844   18924    +4080     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k g123k linked an issue Jul 4, 2024 that may be closed by this pull request
@teolemon teolemon merged commit b1950ac into openfoodfacts:develop Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Crash reports on category addition (and possibly others) on iOS
3 participants