Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Photo gallery for "Others" #5501

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 22, 2024

Hi everyone!

Today, the 'Other' view only displays a single photo and does not allow browsing the gallery.
Now, we have:

  • a swipe gesture to switch between photos
  • network errors are supported
  • a details popup shows info about the picture
  • an indicator if the photo is outdated

Note: the contributor name is not implemented (waiting for openfoodfacts/openfoodfacts-dart#953)

Video:
Gallery.webm

@g123k g123k self-assigned this Jul 22, 2024
@g123k g123k requested a review from a team as a code owner July 22, 2024 10:58
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 7.00%. Comparing base (4d9c7fc) to head (1b701c5).
Report is 258 commits behind head on develop.

Files Patch % Lines
..._app/lib/pages/image/product_image_other_page.dart 0.00% 133 Missing ⚠️
.../pages/image/product_image_gallery_other_view.dart 0.00% 5 Missing ⚠️
...ooth_app/lib/pages/image/product_image_widget.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5501      +/-   ##
==========================================
- Coverage     9.54%   7.00%   -2.54%     
==========================================
  Files          325     397      +72     
  Lines        16411   21001    +4590     
==========================================
- Hits          1567    1472      -95     
- Misses       14844   19529    +4685     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice @g123k 👍

@teolemon teolemon merged commit 344518d into openfoodfacts:develop Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants