Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove flutter_map attribution #5511

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 26, 2024

Hi everyone,

The map on the Product Page has an icon similar to the Google Maps icon:
Screenshot_1722002354

I prefer to disable it, because it's really misleading and I've clicked many times on it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.04%. Comparing base (4d9c7fc) to head (4fdad4f).
Report is 262 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5511      +/-   ##
==========================================
- Coverage     9.54%   7.04%   -2.51%     
==========================================
  Files          325     397      +72     
  Lines        16411   20884    +4473     
==========================================
- Hits          1567    1472      -95     
- Misses       14844   19412    +4568     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

+1

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, we still have OSM attribution, and we have a open licence screen in settings

@teolemon teolemon merged commit ddb127d into openfoodfacts:develop Jul 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants