Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User lists: change the way to switch between lists #5521

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 3, 2024

Hi everyone!

As suggested by @teolemon, the way to switch between user lists is now done by clicking on the title and not the button on the right. It feels more natural:

Screen.Recording.2024-08-03.at.20.00.55.mov

@g123k g123k self-assigned this Aug 3, 2024
@g123k g123k requested a review from a team as a code owner August 3, 2024 18:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 7.01%. Comparing base (4d9c7fc) to head (bc07c7b).
Report is 269 commits behind head on develop.

Files Patch % Lines
...pp/lib/pages/product/common/product_list_page.dart 0.00% 46 Missing ⚠️
packages/smooth_app/lib/resources/app_icons.dart 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5521      +/-   ##
==========================================
- Coverage     9.54%   7.01%   -2.54%     
==========================================
  Files          325     397      +72     
  Lines        16411   21038    +4627     
==========================================
- Hits          1567    1475      -92     
- Misses       14844   19563    +4719     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thank you 👍
We already go on the line for long list names

@g123k g123k changed the title feat: User lists: change the way the switch between lists feat: User lists: change the way to switch between lists Aug 3, 2024
@teolemon teolemon merged commit 7b3cfab into openfoodfacts:develop Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants