feat: improved price product selection #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `price_product_search_page.dart` New file: * `price_add_product_card.dart`: Card where the user can input a price product: type the barcode or scan. Impacted files: * `price_amount_card.dart`: removed the "no product" option; refactored Provider and Controllers * `price_amount_model.dart`: minor refactoring * `price_meta_product.dart`: removed the "no product" option; async load of data (local+server) * `price_model.dart`: minor refactoring * `product_price_add_page.dart`: refactored Provider; now using new widget `PriceAddProductCard` * `user_preferences_account.dart`: minor refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5564 +/- ##
==========================================
- Coverage 9.54% 6.95% -2.60%
==========================================
Files 325 400 +75
Lines 16411 21169 +4758
==========================================
- Hits 1567 1473 -94
- Misses 14844 19696 +4852 ☔ View full report in Codecov by Sentry. |
|
@teolemon @raphael0202 Only some tests to be performed live, and we're good! |
teolemon
approved these changes
Sep 7, 2024
|
Thank you @teolemon for your review! |
Impacted files: * `app_en.arb`: minor changes * `app_fr.arb`: minor changes * `price_add_product_card.dart`: checked duplicate barcodes * `pubspec.lock`: wtf * `pubspec.yaml`: new off-dart version - 3.14
|
In the latest push:
Still need to go on errands in order to double-check the Prices IRL.
|
Impacted files: * `price_add_product_card.dart`: populated the previously scanned barcode * `price_scan_page.dart`: checked if barcode was just previously scanned; added back button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Providerfor those pages, which was not superfluous.Screenshot
Files
Deleted file:
price_product_search_page.dartNew file:
price_add_product_card.dart: Card where the user can input a price product: type the barcode or scan.Impacted files:
price_amount_card.dart: removed the "no product" option; refactored Provider and Controllersprice_amount_model.dart: minor refactoringprice_meta_product.dart: removed the "no product" option; async load of data (local+server)price_model.dart: minor refactoringproduct_price_add_page.dart: refactored Provider; now using new widgetPriceAddProductCarduser_preferences_account.dart: minor refactoring